Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel builds #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix wheel builds #427

wants to merge 1 commit into from

Conversation

aaron-skydio
Copy link
Member

  • Rewriting the egg info stopped working at some point. I'm not sure
    when (they were still getting partly rewritten after the environment
    variable change so it wasn't that). I can't think of a reason not to
    do it this way though, which is simpler.
  • We're more than 300 commits away from the last tag
  • Don't need to install gmp on macos, it's already installed. Not
    a necessary change, just suppresses a warning

Topic: fix-wheels

- Rewriting the egg info stopped working at some point.  I'm not sure
  when (they were still getting partly rewritten after the environment
  variable change so it wasn't that).  I can't think of a reason not to
  do it this way though, which is simpler.
- We're more than 300 commits away from the last tag
- Don't need to install gmp on macos, it's already installed.  Not
  a necessary change, just suppresses a warning

Topic: fix-wheels
@aaron-skydio
Copy link
Member Author

aaron-skydio commented Feb 24, 2025

Reviews in this chain:
#427 Fix wheel builds
 └#426 Bump pybind

@aaron-skydio
Copy link
Member Author

# head base diff date summary
0 8e53c70b d1ced097 diff Feb 24 1:03 AM 2 files changed, 45 insertions(+), 80 deletions(-)

@aaron-skydio aaron-skydio mentioned this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant